Remove StructExprTuple and StructExprUnit #1803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the grammar rules StructExprTuple and StructExprUnit, and removes these as distinct expressions. Instead, a note block is used to let the reader know how the constructors can be accessed in the value namespace. This stems back to the beginning of this documentation, which presumably was presenting these as distinct kinds of expressions just as a simplification or to match what people's mental models might be. However, they are not distinct expressions, and I think it is misleading to pretend that they are. Closes rust-lang#1802
rustbot
added
the
S-waiting-on-review
traviscross
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the grammar rules StructExprTuple and StructExprUnit, and removes these as distinct expressions. Instead, a note block is used to let the reader know how the constructors can be accessed in the value namespace.
This stems back to the beginning of this documentation, which presumably was presenting these as distinct kinds of expressions just as a simplification or to match what people's mental models might be. However, they are not distinct expressions, and I think it is misleading to pretend that they are.
Closes #1802